D7366: revlog: delete references to deleted nullid sentinel value
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Fri Nov 8 22:59:53 UTC 2019
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We stopped keeping the nullid in the index in 781b2720d2ac <https://phab.mercurial-scm.org/rHG781b2720d2ac005e2806b46d8cb91abacfe4b901> (index:
don't include nullid in len(), 2018-07-20). I forgot to update some
comments about it.
REPOSITORY
rHG Mercurial
BRANCH
default
REVISION DETAIL
https://phab.mercurial-scm.org/D7366
AFFECTED FILES
mercurial/cext/revlog.c
CHANGE DETAILS
diff --git a/mercurial/cext/revlog.c b/mercurial/cext/revlog.c
--- a/mercurial/cext/revlog.c
+++ b/mercurial/cext/revlog.c
@@ -62,10 +62,9 @@
* This class has two behaviors.
*
* When used in a list-like way (with integer keys), we decode an
- * entry in a RevlogNG index file on demand. Our last entry is a
- * sentinel, always a nullid. We have limited support for
+ * entry in a RevlogNG index file on demand. We have limited support for
* integer-keyed insert and delete, only at elements right before the
- * sentinel.
+ * end.
*
* With string keys, we lazily perform a reverse mapping from node to
* rev, using a base-16 trie.
@@ -2443,7 +2442,7 @@
/*
* Delete a numeric range of revs, which must be at the end of the
- * range, but exclude the sentinel nullid entry.
+ * range.
*/
static int index_slice_del(indexObject *self, PyObject *item)
{
To: martinvonz, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list