D7337: index: use `index.get_rev` in `repoview.pinnedrevs`

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Fri Nov 8 19:17:47 EST 2019


marmoute added inline comments.
marmoute marked 2 inline comments as done.

INLINE COMMENTS

> indygreg wrote in repoview.py:64
> Nevermind. This `get_rev()` can return `None`.

Yeah, it is simpler to filter out None at the end than to do a lookup before adding to the set.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7337/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7337

To: marmoute, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list