D7311: utils: move the `dirs` definition in a dedicated module (API)

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Fri Nov 8 19:22:15 EST 2019


martinvonz added inline comments.

INLINE COMMENTS

> marmoute wrote in dirstateutil.py:14
> I feel like `pathutil.py` is mostly scm agnostic and I would rather keep it this way.

But how is `dirs` not scm-agnostic? Oh, you mean the ugly `skip` thing? Can we see if we can just remove that instead (move it outside of the class)?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7311/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7311

To: marmoute, durin42, martinvonz, #hg-reviewers, Alphare, indygreg
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list