D7320: revlog: clean up the node of all revision stripped in the C code

[marmoute (Pierre-Yves David)]

marmoute added a comment.
marmoute requested review of this revision.


  In D7320#107577 <https://phab.mercurial-scm.org/D7320#107577>, @indygreg wrote:
  
  > The first element in the index is a sentinel entry for `nullid`. I suspect the `+1` here is meant to ignore that sentinel. The comment for this function clearly calls out this behavior. And I I'm pretty sure this change could result in the sentinel being deleted.
  > So either drop this patch, catch the special case of deleting the sentinel entry, or convince me I'm wrong in my claim that this patch is changing behavior.
  
  Without this change, D7321 <https://phab.mercurial-scm.org/D7321> crash horribly, and debugging show that the value left out is clearly a non-sentinel value that should be deleted.
  
  With this change, D7321 <https://phab.mercurial-scm.org/D7321> pass all test flawlessly.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7320/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7320

To: marmoute, #hg-reviewers, indygreg
Cc: martinvonz, indygreg, mercurial-devel