D7321: revlog: deal with nodemap deletion within the index

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Fri Nov 8 19:31:17 EST 2019


marmoute added a comment.
marmoute requested review of this revision.


  regarding xrange: Same feedback as for D7313 <https://phab.mercurial-scm.org/D7313>, this is a non performance critical section since this is about `pure`.
  
  regarding the sentinel value: The revision we access during deletion are the same as the one actually removed from the index, so this seems correct. In addition, all test are happy.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7321/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7321

To: marmoute, indygreg, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list