D7322: index: add a `has_node` method (API)

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Fri Nov 8 19:32:01 EST 2019


marmoute added inline comments.

INLINE COMMENTS

> indygreg wrote in revlog.c:2071
> `index_contains()` can return `-1` in many cases (including invalid input), which will cast to `True`. So this implementation needs improved.

Good catch ! updating the patch.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7322/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7322

To: marmoute, indygreg, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list