D7168: packaging: install .rc files to hgrc.d

mharbison72 (Matt Harbison) phabricator at mercurial-scm.org
Fri Nov 8 20:09:34 EST 2019


mharbison72 added a comment.
mharbison72 accepted this revision.


  In D7168#107707 <https://phab.mercurial-scm.org/D7168#107707>, @martinvonz wrote:
  
  > In D7168#105270 <https://phab.mercurial-scm.org/D7168#105270>, @indygreg wrote:
  >
  >> In D7168#105269 <https://phab.mercurial-scm.org/D7168#105269>, @mharbison72 wrote:
  >>
  >>> Is it a good idea to encourage people to modify the installation directory?  I thought it was off limits on Windows, though a custom file does seem to survive an uninstall/install cycle of thg.
  >>> I do miss having a global directory like `/etc/mercurial/hgrc.d`.  Loading relative to the exe isn't exactly global, since a vanilla hg vs a thg install will use different directories.  I wonder if we can slip in a global directory under %ProgramData% or %AppData% or similar.
  >>
  >> I agree that we should consider a better solution here. The compatibility story on Windows is not great and there's lots of room for improvement.
  >> Looking in %ProgramData% or %AppData% in addition to a directory next to the executable and in your home directory feels appropriate. As you say, it mirrors on POSIX works with `/etc`.
  >
  > @mharbison72, are you okay with what Greg says?
  > I'll queue the patches up but not including this one for now. Thank, Greg! I don't really know what all these patches do, but the commit messages sound reasonable :)
  
  Yeah, I agree with that. My comment was mostly focused on what was to be indicated in the release notes.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7168/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7168

To: indygreg, #hg-reviewers, mharbison72
Cc: martinvonz, mharbison72, mercurial-devel


More information about the Mercurial-devel mailing list