D7355: index: use `index.has_node` in `phabricator.getoldnodedrevmap`
marmoute (Pierre-Yves David)
phabricator at mercurial-scm.org
Sat Nov 9 03:42:09 EST 2019
Closed by commit rHG03b36cbb8f34: index: use `index.has_node` in `phabricator.getoldnodedrevmap` (authored by marmoute).
This revision was automatically updated to reflect the committed changes.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D7355?vs=17856&id=17880
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7355/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7355
AFFECTED FILES
hgext/phabricator.py
CHANGE DETAILS
diff --git a/hgext/phabricator.py b/hgext/phabricator.py
--- a/hgext/phabricator.py
+++ b/hgext/phabricator.py
@@ -389,7 +389,7 @@
corresponding Differential Revision, and exist in the repo.
"""
unfi = repo.unfiltered()
- nodemap = unfi.changelog.nodemap
+ has_node = unfi.changelog.index.has_node
result = {} # {node: (oldnode?, lastdiff?, drev)}
toconfirm = {} # {node: (force, {precnode}, drev)}
@@ -398,7 +398,7 @@
# For tags like "D123", put them into "toconfirm" to verify later
precnodes = list(obsutil.allpredecessors(unfi.obsstore, [node]))
for n in precnodes:
- if n in nodemap:
+ if has_node(n):
for tag in unfi.nodetags(n):
m = _differentialrevisiontagre.match(tag)
if m:
@@ -454,7 +454,7 @@
if diffs:
lastdiff = max(diffs, key=lambda d: int(d[b'id']))
oldnode = getnode(lastdiff)
- if oldnode and oldnode not in nodemap:
+ if oldnode and not has_node(oldnode):
oldnode = None
result[newnode] = (oldnode, lastdiff, drev)
To: marmoute, #hg-reviewers, indygreg
Cc: Kwan, mercurial-devel
More information about the Mercurial-devel
mailing list