D7368: fuzz: migrate bdiff fuzzer to use FuzzedDataProvider

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Mon Nov 11 22:03:38 EST 2019


Closed by commit rHGdbc39f028c9f: fuzz: migrate bdiff fuzzer to use FuzzedDataProvider (authored by durin42).
This revision was automatically updated to reflect the committed changes.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D7368?vs=18028&id=18035

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7368/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7368

AFFECTED FILES
  contrib/fuzz/bdiff.cc

CHANGE DETAILS

diff --git a/contrib/fuzz/bdiff.cc b/contrib/fuzz/bdiff.cc
--- a/contrib/fuzz/bdiff.cc
+++ b/contrib/fuzz/bdiff.cc
@@ -9,22 +9,20 @@
 #include <memory>
 #include <stdlib.h>
 
-#include "fuzzutil.h"
+#include <fuzzer/FuzzedDataProvider.h>
 
 extern "C" {
 #include "bdiff.h"
 
 int LLVMFuzzerTestOneInput(const uint8_t *Data, size_t Size)
 {
-	auto maybe_inputs = SplitInputs(Data, Size);
-	if (!maybe_inputs) {
-		return 0;
-	}
-	auto inputs = std::move(maybe_inputs.value());
+	FuzzedDataProvider provider(Data, Size);
+	std::string left = provider.ConsumeRandomLengthString(Size);
+	std::string right = provider.ConsumeRemainingBytesAsString();
 
 	struct bdiff_line *a, *b;
-	int an = bdiff_splitlines(inputs.left.get(), inputs.left_size, &a);
-	int bn = bdiff_splitlines(inputs.right.get(), inputs.right_size, &b);
+	int an = bdiff_splitlines(left.c_str(), left.size(), &a);
+	int bn = bdiff_splitlines(right.c_str(), right.size(), &b);
 	struct bdiff_hunk l;
 	bdiff_diff(a, an, b, bn, &l);
 	free(a);



To: durin42, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list