D7384: commands: necessary annotations and suppresssions to pass pytype

dlax (Denis Laxalde) phabricator at mercurial-scm.org
Thu Nov 14 04:45:29 EST 2019


dlax added inline comments.

INLINE COMMENTS

> commands.py:1127
> +            bgood,  # pytype: disable=name-error
> +        )
>          return

This one is sad. I think this can be sorted out by replacing the `try:/finally:` with a context manager. (Can send a patch, if it sounds good to you.)

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7384/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7384

To: durin42, #hg-reviewers
Cc: dlax, mercurial-devel


More information about the Mercurial-devel mailing list