D7400: logcmdutil: use field names instead of field numbers on scmutil.status
durin42 (Augie Fackler)
phabricator at mercurial-scm.org
Thu Nov 14 21:11:16 UTC 2019
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
As part of my pytype adventures I want to make scmutil.status no longer a
subclass of tuple. This is part of that process.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D7400
AFFECTED FILES
mercurial/logcmdutil.py
CHANGE DETAILS
diff --git a/mercurial/logcmdutil.py b/mercurial/logcmdutil.py
--- a/mercurial/logcmdutil.py
+++ b/mercurial/logcmdutil.py
@@ -339,8 +339,11 @@
self._exthook(ctx)
if self.ui.debugflag:
- files = ctx.p1().status(ctx)[:3]
- for key, value in zip([b'files', b'files+', b'files-'], files):
+ files = ctx.p1().status(ctx)
+ for key, value in zip(
+ [b'files', b'files+', b'files-'],
+ [files.modified, files.added, files.removed],
+ ):
if value:
self.ui.write(
columns[key] % b" ".join(value),
@@ -470,9 +473,9 @@
):
files = ctx.p1().status(ctx)
fm.data(
- modified=fm.formatlist(files[0], name=b'file'),
- added=fm.formatlist(files[1], name=b'file'),
- removed=fm.formatlist(files[2], name=b'file'),
+ modified=fm.formatlist(files.modified, name=b'file'),
+ added=fm.formatlist(files.added, name=b'file'),
+ removed=fm.formatlist(files.removed, name=b'file'),
)
verbose = not self.ui.debugflag and self.ui.verbose
To: durin42, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list