D7407: debugcommands: add assertions to convince pytype peer is not None
durin42 (Augie Fackler)
phabricator at mercurial-scm.org
Thu Nov 14 21:12:23 UTC 2019
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This function is moderately annoyingly defined, and peer is set up iff we're
not in raw-proto mode. That's fine, but it confuses pytype. Adding these
assertions is a low-overhead way to convince pytype we're doing reasonable
things.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D7407
AFFECTED FILES
mercurial/debugcommands.py
CHANGE DETAILS
diff --git a/mercurial/debugcommands.py b/mercurial/debugcommands.py
--- a/mercurial/debugcommands.py
+++ b/mercurial/debugcommands.py
@@ -4143,6 +4143,7 @@
_(b'sending batch with %d sub-commands\n')
% len(batchedcommands)
)
+ assert peer is not None
for i, chunk in enumerate(peer._submitbatch(batchedcommands)):
ui.status(
_(b'response #%d: %s\n') % (i, stringutil.escapestr(chunk))
@@ -4223,6 +4224,7 @@
)
elif action == b'close':
+ assert peer is not None
peer.close()
elif action == b'readavailable':
if not stdout or not stderr:
To: durin42, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list