D7381: cmdutil: add a pytype annotation to help out some callsites

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Thu Nov 14 16:15:13 EST 2019


durin42 added inline comments.
durin42 marked an inline comment as done.

INLINE COMMENTS

> dlax wrote in cmdutil.py:3970
> Wouldn't `-> Dict[bytes, List[bytes]]` be okay? (Not sure why "Any" you're referering to in commit message, though I understand `Dict[bytes, Any]` comes from `state.cmdstate.read()` return type in D7383 <https://phab.mercurial-scm.org/D7383>.)

I'm pretty sure that some of the dict values are booleans at the very least?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7381/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7381

To: durin42, #hg-reviewers, dlax
Cc: dlax, mercurial-devel


More information about the Mercurial-devel mailing list