D7376: help: create packages for the help text

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Thu Nov 14 20:15:32 EST 2019


martinvonz added a comment.


  We could also consider removing the `internals/` subdirectory and replacing it by a `internals.` prefix to the filename. Just a thought; I don't care much.
  
  In D7376#108573 <https://phab.mercurial-scm.org/D7376#108573>, @martinvonz wrote:
  
  > Looks good to me, but I don't know Python well enough to say if `mercurial.help` and `mercurial.help.internal` should be "namespace packages" (which I think is what you're doing with the `pkgutil.extend_path()` stuff). I'd appreciate it if someone who knows Python better can comment.
  
  I'm not sure if it's better to make these namespaces or not, but I think it's better to start with regular packages. We can always upgrade them to namespace packages later.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7376/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7376

To: mharbison72, #hg-reviewers, marmoute
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list