D7435: i18n: get datapath directly from resourceutil

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Sat Nov 16 14:08:22 EST 2019


This revision is now accepted and ready to land.
indygreg added inline comments.
indygreg accepted this revision.

INLINE COMMENTS

> i18n.py:57
> +    _ugettext = t.gettext
>  
>  

I'm not thrilled about the use of global variables here: I feel like the locale directory and related functionality should be associated with a `ui` instance or something. But this was an existing can of worms and you didn't make anything worse. So this is fine for now.

REPOSITORY
  rHG Mercurial

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7435/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7435

To: martinvonz, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list