D7252: dirs: reject consecutive slashes in paths

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Tue Nov 19 05:30:29 EST 2019


Alphare added a comment.


  Sorry to necropost, but since this broke the Rust implementation, I was wondering what the best approach would be to replicate this behavior, and I am starting to think that this should be reverted.
  
  IIUC, currently any new path passes through the `pathauditor` first for validation, so any further check would be completely redundant. 
  My intuition is that adding this check is purely here to satisfy the fuzzer, but would never happen in real life. Adding checks to this (very) internal data structure comes at a cost, both in performance and in code ergonomics.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7252/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7252

To: durin42, #hg-reviewers, indygreg
Cc: Alphare, mercurial-devel


More information about the Mercurial-devel mailing list