D7503: rust-dirs: address failing tests for `dirs` impl with a temporary fix

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Fri Nov 22 12:50:21 EST 2019


marmoute added inline comments.

INLINE COMMENTS

> Alphare wrote in lib.rs:117
> This patch is a minimal effort to stick to the C and Python implementations until a decision is reached. Should we decide to keep this code, I would be for having the path included in the error.

This seems fine.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7503/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7503

To: Alphare, #hg-reviewers
Cc: marmoute, durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list