D7295: pytype: add a (very slow) test that executes pytype
mharbison72 (Matt Harbison)
phabricator at mercurial-scm.org
Fri Nov 22 17:43:28 EST 2019
mharbison72 added a comment.
In D7295#107482 <https://phab.mercurial-scm.org/D7295#107482>, @indygreg wrote:
> Since type checking is slow (but there are state files we can reuse to speed things up), we'll need to figure out how to make this work in CI. But I have no doubt we can figure something out. Out of curiosity, how long does pytype take to run in a clean source directory, without any state files?
It takes 15-20 minutes on a 2018 Mac mini. In addition to the disabled files here, I've disabled:
mercurial/httppeer.py
mercurial/repoview.py
mercurial/localrepo.py
mercurial/revlog.py
mercurial/merge.py
mercurial/testing/storage.py
But I've also added back these, and sprinkled various disable comments around:
mercurial/bundlerepo.py
mercurial/error.py
mercurial/exchange.py
mercurial/policy.py
mercurial/pycompat.py
mercurial/scmwindows.py
mercurial/windows.py
mercurial/wireprotoframing.py
Even with the state files, it seems to take 10-15 minutes or so.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7295/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7295
To: durin42, #hg-reviewers, indygreg
Cc: mharbison72, dlax, indygreg, mjpieters, mercurial-devel
More information about the Mercurial-devel
mailing list