D7506: phabricator: add a "phabstatus" show view

dlax (Denis Laxalde) phabricator at mercurial-scm.org
Sat Nov 23 05:15:21 EST 2019


dlax added a comment.
dlax planned changes to this revision.


  In D7506#110321 <https://phab.mercurial-scm.org/D7506#110321>, @mharbison72 wrote:
  
  > In D7506#110288 <https://phab.mercurial-scm.org/D7506#110288>, @mharbison72 wrote:
  >
  >> I'm not sure why, but this version seems to also show obsolete revisions.  I've got a bunch of `x` and `*` nodes in hg-committed right now.  I didn't see that before, although that was on a different clone that I don't have access to now.
  >
  > After further review, the obsolete revisions have unstable children going way back, so that's why they show.  But I'm super confused by the output.  This isn't the whole output, but the middle or so that corresponds to the latest(!) commits:
  
  Hm, I don't have this issue. Even with visible obsolete revisions with a phab differential, the output seem consistent with "show work".
  The revisions shown by the "phabstatus" view is just a subset of that of "work" view (subset of revisions with a differential). Do you see more revisions in "phabstatus" than in "work" or am I misunderstanding something?
  Or perhaps this is because of a wrong sorting of the filtered set? I'll make sure the final is still topo sorted and send another version in a moment.
  
  > Is the goal to limit to the current stack, or all non public commits?  I can see a use case for both.
  
  I don't use the "stack" view often, so my goal is to map to the "work" view which I use more. But perhaps it'd make sense to have "hg show phabwork" and "hg show phabstack"? (We can rename the view, and add the other one later on.)

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7506/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7506

To: dlax, #hg-reviewers
Cc: mharbison72, mjpieters, Kwan, mercurial-devel


More information about the Mercurial-devel mailing list