D7510: windows: suppress pytype warnings for Windows imports and functions

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Sat Nov 23 19:58:30 EST 2019


indygreg added a comment.


  In D7510#110343 <https://phab.mercurial-scm.org/D7510#110343>, @mharbison72 wrote:
  
  > I'm not sure if there are plans to vendor *.pyi files.  Maybe that could be used to backfill platform specific modules instead of doing this.  But for now is seems better to get the error count and blacklist length reduced.
  
  I think `.pyi` files are a bit annoying. And since Python 2 support isn't long for this world, I think we should hold out and just switch to inline type annotations as soon as we drop Python 2 support. This assumes we make good on our plan to drop Python 2 after the first release in 2020 at latest. If not, we should consider vendoring `.pyi` files so we can have nicer things sooner.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7510/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7510

To: mharbison72, #hg-reviewers, dlax
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list