D7512: exchange: guard against method invocation on `b2caps=None` args
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Sun Nov 24 00:16:24 EST 2019
yuja added a comment.
> """add a changegroup part to the requested bundle"""
>
> - if not kwargs.get('cg', True):
>
> + if not kwargs.get('cg', True) or not b2caps:
>
> return
Is it valid to call these functions with `b2caps=None`? I suspect it would
be a bug or a data corruption.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7512/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7512
To: mharbison72, #hg-reviewers, dlax, indygreg
Cc: yuja, mercurial-devel
More information about the Mercurial-devel
mailing list