D7503: rust-dirs: address failing tests for `dirs` impl with a temporary fix
Alphare (Raphaël Gomès)
phabricator at mercurial-scm.org
Mon Nov 25 05:25:54 EST 2019
Alphare added a comment.
In D7503#110345 <https://phab.mercurial-scm.org/D7503#110345>, @yuja wrote:
> Many unhandled results:
Ah sorry, the cargo compilation cache hid those warnings from me, I usually catch them.
> Might be better to do `path.check_state()` in cpython layer, and insert
> `debug_assert` to hg-core.
That would be cleaner for the current purposes, but using `debug_assert` in `hg-core` indicates to me that we want the Rust code to not worry about checking for consecutive slashes in `dirs`, because we would have the `pathauditor`. Am I correct?
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7503/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7503
To: Alphare, #hg-reviewers
Cc: yuja, marmoute, durin42, kevincox, mercurial-devel
More information about the Mercurial-devel
mailing list