D7503: rust-dirs: address failing tests for `dirs` impl with a temporary fix

Yuya Nishihara yuya at tcha.org
Fri Nov 29 09:55:26 EST 2019


>   >>   > Okay, then using non-debug `assert!()` seems more appropriate. If we prefer
>   >>   > being stricter, "checked" HgPath type can be introduced.
>   >>   > ...
>   >>   > Actually I tried to suppress these warnings by propagating Result upwards,
>   >>   > and I got a feeling that we're doing wrong.
>   >>   I sent a followup as D7522 <https://phab.mercurial-scm.org/D7522> because that gets rid of the warnings. As explained in the commit message, I am unhappy about this change, as you seem to be.
>   >
>   > Thanks. Given Rust impl is still unstable, I think it's better to back out
>   > the changes in Rust and leave the test failure until we find a right solution.
>   
>   I am -1 for this. Having the test broken is a big overhead for people actually using Rust and testing it. The rust support is experimental but not "unstable". We use it in production in a couple of places. Keeping the test suite

Well, IMHO, it's as unstable as Python 3. Core features should work, but I
think it's okay to opt out some "known to be broken" tests so long as the
test failure makes sense.

I felt the changes were too much to make Rust implementation behaves exactly
in the same way as C one. If not, I would send the fix last weekend instead
of getting around the phabricator email.


More information about the Mercurial-devel mailing list