D6976: contrib: remove check-code line length limit
durin42 (Augie Fackler)
phabricator at mercurial-scm.org
Sat Oct 5 15:01:37 UTC 2019
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Both Python and C code are managed by formatters now, so relax this.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6976
AFFECTED FILES
contrib/check-code.py
CHANGE DETAILS
diff --git a/contrib/check-code.py b/contrib/check-code.py
--- a/contrib/check-code.py
+++ b/contrib/check-code.py
@@ -364,7 +364,6 @@
# python code fragments embedded in test scripts. Fixing test
# scripts for these patterns requires many changes, and has less
# profit than effort.
- (r'.{81}', "line too long"),
(r'raise Exception', "don't raise generic exceptions"),
(r'[\s\(](open|file)\([^)]*\)\.read\(',
"use util.readfile() instead"),
@@ -462,7 +461,6 @@
(r'//', "don't use //-style comments"),
(r'\S\t', "don't use tabs except for indent"),
(r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"),
- (r'.{81}', "line too long"),
(r'(while|if|do|for)\(', "use space after while/if/do/for"),
(r'return\(', "return is not a function"),
(r' ;', "no space before ;"),
To: durin42, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list