D6971: formatting: blacken the codebase
durin42 (Augie Fackler)
phabricator at mercurial-scm.org
Sat Oct 5 11:53:10 EDT 2019
durin42 added a comment.
Current test failures:
--- /usr/local/google/home/augie/hgtest/tests/test-check-code.t
+++ /usr/local/google/home/augie/hgtest/tests/test-check-code.t.err
@@ -27,9 +27,40 @@
Skipping contrib/packaging/hgpackaging/wix.py it has no-che?k-code (glob)
Skipping contrib/packaging/inno/build.py it has no-che?k-code (glob)
Skipping contrib/packaging/wix/build.py it has no-che?k-code (glob)
+ doc/check-seclevel.py:50:
+ > ui.note('checking "%s"\n' % name)
+ missing _() in ui message (use () to hide false-positives)
+ doc/check-seclevel.py:73:
+ > ui.warn('gap of section level at "%s" of %s\n' % (title, name))
+ missing _() in ui message (use () to hide false-positives)
+ doc/check-seclevel.py:77:
+ > ui.note(
+ missing _() in ui message (use () to hide false-positives)
+ doc/check-seclevel.py:91:
+ > ui.note('skip checking %s: no help document\n' % (namefmt % name))
+ missing _() in ui message (use () to hide false-positives)
+ doc/check-seclevel.py:116:
+ > ui.note('skip checking %s extension: no help document\n' % name)
+ missing _() in ui message (use () to hide false-positives)
+ doc/check-seclevel.py:141:
+ > ui.note(
+ missing _() in ui message (use () to hide false-positives)
+ hgext/convert/cvsps.py:155:
+ > open(os.path.join(b'CVS', b'Repository'), b'rb').read().strip()
+ always assign an opened file to a variable, and close it afterwards
Skipping i18n/polib.py it has no-che?k-code (glob)
+ mercurial/encoding.py:71:
+ > (k.encode(r'utf-8'), v.encode(r'utf-8')) for k, v in os.environ.items()
+ use encoding.environ instead (py3)
+ mercurial/encoding.py:251:
+ > for k, v in os.environ.items()
+ use encoding.environ instead (py3)
+ mercurial/pycompat.py:204:
+ > if not isinstance(s, (bytes, bytearray)) and not hasattr(
+ hasattr(foo, bar) is broken on py2, use util.safehasattr(foo, bar) instead
Skipping mercurial/statprof.py it has no-che?k-code (glob)
Skipping tests/badserverext.py it has no-che?k-code (glob)
+ [1]
@commands in debugcommands.py should be in alphabetical order.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6971/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6971
To: durin42, indygreg, martinvonz, #hg-reviewers
Cc: mjpieters, Kwan, mercurial-devel
More information about the Mercurial-devel
mailing list