D6987: strip: move strip extension to core

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Sat Oct 5 17:02:16 EDT 2019


durin42 added inline comments.

INLINE COMMENTS

> navaneeth.suresh wrote in commands.py:5646
> i see. do i need to replace `strip` by `debugstrip` on every occurrence in tests? otherwise, i would have to revert the changes in the tests and keep the extension as it is.

One or two is fine, you can leave the majority on the legacy extension flavor. We want some using each so we don't have to add a new test to test one of them.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6987/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6987

To: navaneeth.suresh, durin42, #hg-reviewers
Cc: mjpieters, mercurial-devel


More information about the Mercurial-devel mailing list