D6989: push: support config option to require revs be specified when running push

spectral (Kyle Lippincott) phabricator at mercurial-scm.org
Sun Oct 6 09:50:07 EDT 2019


spectral added a comment.


  In D6989#102437 <https://phab.mercurial-scm.org/D6989#102437>, @indygreg wrote:
  
  > Question: should this checking be performed in `exchange.push` or at the command layer?
  > (I'm not sure of the answer.)
  
  I think where it is makes sense - I'd be wary of pushing it down any further having a much larger area of effect (or, conversely, no effect - it's possible that further down we //always// have the revs specified). This is also where it is for `commands.update.requiredest`.

INLINE COMMENTS

> commands.py:4648
>                                  'empty set'))
> +    elif ui.configbool('commands', 'push.require-revs'):
> +        raise error.Abort(_('no revisions specified to push'),

Do we want to have this have the old behavior if plain? commands.update.requiredest doesn't respect plain. I don't think that it makes sense (or at least - it doesn't make sense to have a category for it: `HGPLAINEXCEPT=make-me-specify-revs-to-push` seems like it won't really be useful. :)

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6989/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6989

To: spectral, #hg-reviewers
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list