D6976: contrib: remove check-code line length limit

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Sun Oct 6 09:55:00 EDT 2019


Closed by commit rHG63e25ae9cdce: contrib: remove check-code line length limit (authored by durin42).
This revision was automatically updated to reflect the committed changes.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D6976?vs=16825&id=16871

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6976/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6976

AFFECTED FILES
  contrib/check-code.py

CHANGE DETAILS

diff --git a/contrib/check-code.py b/contrib/check-code.py
--- a/contrib/check-code.py
+++ b/contrib/check-code.py
@@ -364,7 +364,6 @@
     # python code fragments embedded in test scripts. Fixing test
     # scripts for these patterns requires many changes, and has less
     # profit than effort.
-    (r'.{81}', "line too long"),
     (r'raise Exception', "don't raise generic exceptions"),
     (r'[\s\(](open|file)\([^)]*\)\.read\(',
      "use util.readfile() instead"),
@@ -462,7 +461,6 @@
     (r'//', "don't use //-style comments"),
     (r'\S\t', "don't use tabs except for indent"),
     (r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"),
-    (r'.{81}', "line too long"),
     (r'(while|if|do|for)\(', "use space after while/if/do/for"),
     (r'return\(', "return is not a function"),
     (r' ;', "no space before ;"),



To: durin42, #hg-reviewers, indygreg
Cc: mercurial-devel


More information about the Mercurial-devel mailing list