D7008: py3: stop injecting pycompat.hasattr into modules
Augie Fackler
raf at durin42.com
Sun Oct 6 23:58:50 EDT 2019
I'd actually rather not - safehasattr is not required on py3.
On Sun, Oct 6, 2019 at 11:27 PM martinvonz (Martin von Zweigbergk)
<phabricator at mercurial-scm.org> wrote:
>
> martinvonz added inline comments.
>
> INLINE COMMENTS
>
> > statprof.py:171
> > self.sample_interval = 1.0 / frequency
> > - elif not hasattr(self, 'sample_interval'):
> > + elif not pycompat.hasattr(self, 'sample_interval'):
> > # default to 1000 Hz
>
> Should we switch to `util.safehasattr()` for consistency?
>
> REPOSITORY
> rHG Mercurial
>
> CHANGES SINCE LAST ACTION
> https://phab.mercurial-scm.org/D7008/new/
>
> REVISION DETAIL
> https://phab.mercurial-scm.org/D7008
>
> To: indygreg, #hg-reviewers
> Cc: martinvonz, mercurial-devel
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
More information about the Mercurial-devel
mailing list