D6939: sidedata: apply basic but tight security around exchange
marmoute (Pierre-Yves David)
phabricator at mercurial-scm.org
Mon Oct 7 20:51:48 EDT 2019
marmoute added inline comments.
marmoute marked an inline comment as done.
> martinvonz wrote in bundle2.py:1837-1838
> Isn't `bool()` redundant here?
It is redundant, but helping Raphaël work on Rust got me scared about boolean. I'll clean it up (either resend or followup)
> indygreg wrote in bundle2.py:2343
> Shouldn't this by `exp-sidedata`?
Hum, yeah. That would be safer. Updated code coming
CHANGES SINCE LAST ACTION
To: marmoute, #hg-reviewers
Cc: indygreg, martinvonz, mercurial-devel
More information about the Mercurial-devel