D6987: strip: move strip extension to core as debugstrip

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Mon Oct 7 21:06:31 EDT 2019


marmoute added inline comments.

INLINE COMMENTS

> strip.py:1-47
>  """strip changesets and their descendants from history
>  
> -This extension allows you to strip changesets and all their descendants from the
> -repository. See the command help for details.
> +strip extension has been renamed to debugstrip and moved to core. However,
> +this extension is to preserve the old `strip` name forusers that are used
> +to that.
>  """
> +

Why do we need that much code to remain into `hgext/strip.py`. What I would expect to see is a very small file that only register debugstrip as `strip`.

> strip.py:24-34
> +    [
> +     ('r', 'rev', [], _('strip specified revision (optional, can specify '
> +                        'revisions without this option)'), _('REV')),
> +     ('f', 'force', None, _('force removal of changesets, discard uncommitted'
> +                            ' changes (no backup)')),
> +     ('', 'no-backup', None, _('do not save backup bundle')),
> +     ('', 'nobackup', None, _('do not save backup bundle (DEPRECATED)')),

What is going on here? IT seems like the same code with a different formatting.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6987/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6987

To: navaneeth.suresh, durin42, #hg-reviewers
Cc: marmoute, mjpieters, mercurial-devel


More information about the Mercurial-devel mailing list