D7020: pycompat: implement a shlexquote that properly handles bytes

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Tue Oct 8 06:33:53 EDT 2019


marmoute added inline comments.

INLINE COMMENTS

> pycompat.py:343
> +        s = shlex.quote(s)
> +        return s.encode('latin-1')
> +

It might be a silly questions, but why are we going through `latin-1` instead of `utf-8` or any other crazy encoding ?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7020/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7020

To: indygreg, #hg-reviewers
Cc: marmoute, mercurial-devel


More information about the Mercurial-devel mailing list