D7028: cleanup: join string literals that are already on one line

spectral (Kyle Lippincott) phabricator at mercurial-scm.org
Tue Oct 8 18:49:54 EDT 2019


spectral added a comment.
spectral accepted this revision.


  Some slightly disappointing loss of clarity where we had originally had something like:
  
    foo(b'abc\n'
        b'def')
  
  and this became `foo('abc\n' b'def')`, which is now `foo('abc\ndef')`: I liked the newlines ending the string and us being able to see an actual newline in the source, but that's already been lost, and this isn't making it worse in any way.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7028/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7028

To: martinvonz, indygreg, durin42, #hg-reviewers, spectral
Cc: spectral, mjpieters, Kwan, mercurial-devel


More information about the Mercurial-devel mailing list