D6951: sidedatacopies: get and store sidedata in the changelogrevision object

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Wed Oct 9 13:19:53 EDT 2019


martinvonz added inline comments.

INLINE COMMENTS

> changelog.py:618-624
> +        c = changelogrevision(*self._revisiondata(node))
>          return (c.manifest, c.user, c.date, c.files, c.description, c.extra)
>  
>      def changelogrevision(self, nodeorrev):
>          """Obtain a ``changelogrevision`` for a node or revision."""
> -        return changelogrevision(self.revision(nodeorrev))
> +        text, sidedata = self._revisiondata(nodeorrev)
> +        return changelogrevision(text, sidedata)

nit: inconsistent way of calling the `changelogrevision` constructor between these two call sites

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6951/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6951

To: marmoute, #hg-reviewers
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list