D6953: sidedatacopies: read rename information from sidedata
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Wed Oct 9 13:45:56 EDT 2019
martinvonz added inline comments.
> + if rawindices is not None:
> + rawindices = decodefileindices(self.files, rawindices)
> + return rawindices
Calling the list of filenames `rawindices` is misleading. I see that you've changed this code to return an empty list of files when the list of indices was itself an empty list. That makes sense. Could you extract that to a separate patch ? Does it matter in practice for sidedata? Please explain in the commit message if it does. That patch would also assign the decoded list of indices to a variable called `files` or something like that.
CHANGES SINCE LAST ACTION
To: marmoute, #hg-reviewers
Cc: martinvonz, mercurial-devel
More information about the Mercurial-devel