D6953: sidedatacopies: read rename information from sidedata
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Wed Oct 9 14:33:38 EDT 2019
martinvonz added inline comments.
> marmoute wrote in changelog.py:369-371
> > I see that you've changed this code to return an empty list of files when the list of indices was itself an empty list.
> I dont' follow this sentence. What do you mean ?
I thought the reason you explicitly did `if rawindices is not None` was in order to not run the next statement if `rawindices` was an empty list. But that should have no effect anyway, so I was clearly wrong about that. So why did you make the `is not None` explicit? Can you just revert it if there was no good reason for it?
CHANGES SINCE LAST ACTION
To: marmoute, #hg-reviewers
Cc: martinvonz, mercurial-devel
More information about the Mercurial-devel