D6953: sidedatacopies: read rename information from sidedata
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Wed Oct 9 14:39:01 EDT 2019
martinvonz added inline comments.
INLINE COMMENTS
> marmoute wrote in context.py:536-550
> I think I prefer my version for being a bit more explicite (all `if`s are positive) and hence easier to read for people new to this code. However, I don't mind your version if you really want it that way. Just let me know.
Is there a way of writing `self._repo.filecopiesmode != b'changeset-sidedata'` in positive way? Maybe `self._repo.filecopiesmode is None`? The `source != b'changeset-only'` is because we want any invalid/unexpected config to be treated as "filelog-only".
I won't insist on changing.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6953/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6953
To: marmoute, #hg-reviewers
Cc: martinvonz, mercurial-devel
More information about the Mercurial-devel
mailing list