D6953: sidedatacopies: read rename information from sidedata

Wed Oct 9 17:49:51 EDT 2019

martinvonz added inline comments.

INLINE COMMENTS

> marmoute wrote in changelog.py:369-371
> Yes, this is to handle `b''` in  different way from `None`.

Actually, both `decodefileindices()` and `decodecopies()` seem to properly handle the "empty input" case. So I think you can revert this change. As I suggested earlier, it may be best as a separate patch anyway since it seems unrelated to this patch (although maybe it is required by, if I'm still misunderstanding and it really is a bug). Sorry I didn't notice this earlier.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6953/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6953

To: marmoute, #hg-reviewers
Cc: martinvonz, mercurial-devel