D6953: sidedatacopies: read rename information from sidedata
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Wed Oct 9 17:49:51 EDT 2019
martinvonz added inline comments.
> marmoute wrote in changelog.py:369-371
> Yes, this is to handle `b''` in different way from `None`.
Actually, both `decodefileindices()` and `decodecopies()` seem to properly handle the "empty input" case. So I think you can revert this change. As I suggested earlier, it may be best as a separate patch anyway since it seems unrelated to this patch (although maybe it is required by, if I'm still misunderstanding and it really is a bug). Sorry I didn't notice this earlier.
CHANGES SINCE LAST ACTION
To: marmoute, #hg-reviewers
Cc: martinvonz, mercurial-devel
More information about the Mercurial-devel