D7045: phabricator: add the maketext function
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Fri Oct 11 21:46:55 EDT 2019
This revision is now accepted and ready to land.
indygreg added inline comments.
indygreg accepted this revision.
INLINE COMMENTS
> phabricator.py:557
> + diffopts = mdiff.diffopts(git=True, context=32767)
> + _pfctx, _fctx, header, fhunks = next(
> + patch.diffhunks(repo, ctx.p1(), ctx, fmatcher, opts=diffopts)
The use of a single `next()` is a bit weird. But I suppose it gets the job done since we're expecting at most one file's diff.
REPOSITORY
rHG Mercurial
BRANCH
default
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7045/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7045
To: Kwan, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel
More information about the Mercurial-devel
mailing list