D7055: phabricator: update hgmatcher to cope with the new data format

Kwan (Ian Moody) phabricator at mercurial-scm.org
Sat Oct 12 10:02:17 EDT 2019


Kwan added inline comments.

INLINE COMMENTS

> phabricator.py:155-156
> +            if value.startswith(b'{') and value.endswith(b'}'):
> +                r1json = json.loads(value)
> +                r2json = json.loads(r2params[key][0])
> +                if r1json != r2json:

These will need converting to unicode first for py3.5 (I keep forgetting about loads only accepting bytes from 3.6 onwards).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7055/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7055

To: Kwan, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list