D7080: hghave: use a native string to invoke the `black` command
mharbison72 (Matt Harbison)
phabricator at mercurial-scm.org
Sun Oct 13 02:31:36 UTC 2019
mharbison72 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Windows can't create a process based on bytes. Apparently only the output test
in `matchoutput` wants bytes.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D7080
AFFECTED FILES
tests/hghave.py
CHANGE DETAILS
diff --git a/tests/hghave.py b/tests/hghave.py
--- a/tests/hghave.py
+++ b/tests/hghave.py
@@ -984,8 +984,8 @@
@check('grey', 'grey, the fork of the black formatter for python')
def has_black():
# use that to actual black as soon as possible
- # blackcmd = b'black --version'
- blackcmd = b'python3 $RUNTESTDIR/../contrib/grey.py --version'
+ # blackcmd = 'black --version'
+ blackcmd = 'python3 $RUNTESTDIR/../contrib/grey.py --version'
# version_regex = b'black, version \d'
version_regex = b'grey.py, version \d'
return matchoutput(blackcmd, version_regex)
To: mharbison72, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list