D7086: fix: remove a never-true check for unset pattern in Fixer.affects()
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Mon Oct 14 06:39:53 UTC 2019
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We don't create an instance of a Fixer if the pattern is None, so we
don't need to check that in affects().
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D7086
AFFECTED FILES
hgext/fix.py
CHANGE DETAILS
diff --git a/hgext/fix.py b/hgext/fix.py
--- a/hgext/fix.py
+++ b/hgext/fix.py
@@ -845,9 +845,7 @@
def affects(self, opts, fixctx, path):
"""Should this fixer run on the file at the given path and context?"""
- return self._pattern is not None and scmutil.match(
- fixctx, [self._pattern], opts
- )(path)
+ return scmutil.match(fixctx, [self._pattern], opts)(path)
def shouldoutputmetadata(self):
"""Should the stdout of this fixer start with JSON and a null byte?"""
To: martinvonz, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list