D7086: fix: remove a never-true check for unset pattern in Fixer.affects()

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Mon Oct 14 13:10:21 EDT 2019


Closed by commit rHG96c4c6f37d52: fix: remove a never-true check for unset pattern in Fixer.affects() (authored by martinvonz).
This revision was automatically updated to reflect the committed changes.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D7086?vs=17131&id=17144

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7086/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7086

AFFECTED FILES
  hgext/fix.py

CHANGE DETAILS

diff --git a/hgext/fix.py b/hgext/fix.py
--- a/hgext/fix.py
+++ b/hgext/fix.py
@@ -845,9 +845,7 @@
 
     def affects(self, opts, fixctx, path):
         """Should this fixer run on the file at the given path and context?"""
-        return self._pattern is not None and scmutil.match(
-            fixctx, [self._pattern], opts
-        )(path)
+        return scmutil.match(fixctx, [self._pattern], opts)(path)
 
     def shouldoutputmetadata(self):
         """Should the stdout of this fixer start with JSON and a null byte?"""



To: martinvonz, #hg-reviewers, pulkit
Cc: hooper, mercurial-devel


More information about the Mercurial-devel mailing list