D7075: copies: add an explicit test using multiple roots

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Tue Oct 15 01:32:49 EDT 2019


martinvonz added inline comments.

INLINE COMMENTS

> test-copies-unrelated.t:398
> +
> +Copies involving multiple roots.
> +

nit: maybe "involving *merge* of multiple roots" to clarify how it's different from the case above

> test-copies-unrelated.t:403-406
> +  $ echo a >> a
> +  $ hg ci -Aqm 'update a'
> +  $ echo a >> a
> +  $ hg ci -Aqm 'update a'

nit: These seem unlikely to have any effect on the result. remove them? Or at least one of them? OTOH, you seem to have deliberately made the contents match in revision 2 and revision 7. What's the reason for that? Did that trigger a bug in an earlier version of this series?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7075/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7075

To: marmoute, #hg-reviewers
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list