D7070: copies: extract data extraction into a `revinfo` function

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Tue Oct 15 08:56:55 EDT 2019


martinvonz added a comment.


  In D7070#104170 <https://phab.mercurial-scm.org/D7070#104170>, @martinvonz wrote:
  
  > In D7070#104159 <https://phab.mercurial-scm.org/D7070#104159>, @marmoute wrote:
  >
  >> In D7070#104100 <https://phab.mercurial-scm.org/D7070#104100>, @martinvonz wrote:
  >>
  >>> The extracted function slows down `hg perfpathcopies FIREFOX_BETA_59_END FIREFOX_BETA_60_BASE` (not merge-heavy) from 3.55s to 3.87s, but since you also changed `ctx.p[12]copies()` to `ctx._copies` it ended up being a net speed improvement (3.24s including for the patch as written).
  >>
  >> Which method are you using on this repository ? extra+changeset-only ?
  >
  > Yes.
  
  Sorry, I should say that that's of course I version of mozilla-unified that I've converted. Let me know if you want a copy of it, but I suspect that you'll see similar numbers in your repos.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7070/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7070

To: marmoute, #hg-reviewers
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list