D7060: rust-dirstate-status: add call to rust-fast path for `dirstate.status`
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Wed Oct 16 17:35:30 EDT 2019
This revision is now accepted and ready to land.
martinvonz added inline comments.
martinvonz accepted this revision.
INLINE COMMENTS
> dirstate.py:1120-1127
> + lookup, modified, added, removed, deleted, unknown, clean = rustmod.status(
> + dmap._rustmap,
> + self._rootdir,
> + match.files(),
> + bool(listclean),
> + self._lastnormaltime,
> + self._checkexec,
contrib/grey.py wants is not happy with the formatting. I'll fix it in flight.
> dirstate.py:1107
> + use_rust = False
> + if bool(listunknown):
> + # Pathauditor does not exist yet in Rust, unknown files
nit: the `bool()` wrapping is probably not necessary (and it's inconsistent with line the check for `listignored` a few lines down)
> dirstate.py:1134-1137
> + status = scmutil.status(modified=modified, added=added,
> + removed=removed, deleted=deleted,
> + unknown=unknown, ignored=ignored,
> + clean=clean)
same here
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7060/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7060
To: Alphare, #hg-reviewers, martinvonz
Cc: martinvonz, mjpieters, mercurial-devel
More information about the Mercurial-devel
mailing list