D7105: dirs: reject consecutive slashes in paths

[indygreg (Gregory Szorc)]

indygreg added a comment.


  I dropped this from committed because of discussion on this review and because Windows was not happy with the change:
  
    mercurial/cext/dirs.c(75) : error C2275: 'PyObject' : illegal use of this type as an expression
            c:\dev\python27-64\include\object.h(108) : see declaration of 'PyObject'
    mercurial/cext/dirs.c(75) : error C2065: 'val' : undeclared identifier
    mercurial/cext/dirs.c(81) : error C2065: 'val' : undeclared identifier
    mercurial/cext/dirs.c(81) : warning C4047: '=' : 'int' differs in levels of indirection from 'PyObject *'
    mercurial/cext/dirs.c(82) : error C2065: 'val' : undeclared identifier
    mercurial/cext/dirs.c(82) : warning C4047: '!=' : 'int' differs in levels of indirection from 'void *'
    mercurial/cext/dirs.c(83) : error C2065: 'val' : undeclared identifier
    mercurial/cext/dirs.c(92) : error C2065: 'val' : undeclared identifier
    mercurial/cext/dirs.c(92) : warning C4047: '=' : 'int' differs in levels of indirection from 'PyObject *'
    mercurial/cext/dirs.c(95) : error C2065: 'val' : undeclared identifier
    mercurial/cext/dirs.c(95) : warning C4047: '==' : 'int' differs in levels of indirection from 'void *'
    mercurial/cext/dirs.c(98) : error C2065: 'val' : undeclared identifier
    mercurial/cext/dirs.c(99) : error C2065: 'val' : undeclared identifier
    mercurial/cext/dirs.c(99) : warning C4047: 'function' : 'PyObject *' differs in levels of indirection from 'int'
    mercurial/cext/dirs.c(99) : warning C4024: 'PyDict_SetItem' : different types for formal and actual parameter 3
    mercurial/cext/dirs.c(100) : error C2065: 'val' : undeclared identifier
    mercurial/cext/dirs.c(100) : error C2065: 'val' : undeclared identifier
    mercurial/cext/dirs.c(100) : error C2065: 'val' : undeclared identifier
    error: command 'C:\\Users\\gps\\AppData\\Local\\Programs\\Common\\Microsoft\\Visual C++ for Python\\9.0\\VC\\Bin\\amd64\\cl.exe' failed with exit status 2
  
  TBH I'm not sure what's going on there. Perhaps a bad byte/newline sequence in the file?
  
  `1f04c51d52eadb12bfbb6fba8eca27e742ea88d4` is the node that was dropped.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7105/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7105

To: durin42, #hg-reviewers, indygreg
Cc: yuja, indygreg, mercurial-devel