D7128: rust-dirstate-status: use fast-path even with fsmonitor and sparse extensions

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Thu Oct 17 19:31:01 EDT 2019


Alphare created this revision.
Herald added subscribers: mercurial-devel, mjpieters.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  When I initially ran the tests on my series, there were test failures related
  to those extensions. Now that the initial series has landed, I felt like going
  back to those issues because people with performance issues will often want to
  use fsmonitor and sparse.
  
  Either because of flaky tests or because the series has changed so much, I
  can't seem to reproduce these issues... let's widen the scope of the fast-path.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D7128

AFFECTED FILES
  mercurial/dirstate.py

CHANGE DETAILS

diff --git a/mercurial/dirstate.py b/mercurial/dirstate.py
--- a/mercurial/dirstate.py
+++ b/mercurial/dirstate.py
@@ -1115,11 +1115,6 @@
         elif not match.always():
             # Matchers have yet to be implemented
             use_rust = False
-        # We don't yet have a mechanism for extensions
-        elif sparse.enabled:
-            use_rust = False
-        elif not getattr(self, "_fsmonitordisable", True):
-            use_rust = False
 
         if use_rust:
             (



To: Alphare, #hg-reviewers
Cc: mjpieters, mercurial-devel


More information about the Mercurial-devel mailing list