[PATCH 3 of 9] rust-cpython: add generation counter to leaked reference

Yuya Nishihara yuya at tcha.org
Sat Oct 19 22:49:00 EDT 2019

On Sat, 19 Oct 2019 22:07:01 +0200, Raphaël Gomès wrote:
> On 10/19/19 12:07 PM, Yuya Nishihara wrote:
> > +    #[should_panic(expected = "map() over invalidated leaked reference")]
> Should we keep a "registry" of those hardcoded errors? To me they feel 
> like magic numbers. I could be nitpicking a little too hard though

Do you mean the message should be extracted to a const str?

I don't feel like that since I just wanted to easily make sure that map()
panics. The exact message isn't important. To make the test more robust,
maybe it's better to add a non-panicking version of the map() function.

More information about the Mercurial-devel mailing list