[PATCH] grep: warn on censored revisions instead of erroring out

Jordi Gutiérrez Hermoso jordigh at octave.org
Tue Oct 22 10:04:01 EDT 2019


On Tue, 2019-10-22 at 10:39 +0900, Yuya Nishihara wrote:
> On Mon, 21 Oct 2019 16:10:58 -0400, Jordi Gutiérrez Hermoso wrote:
> > # HG changeset patch
> > # User Jordi Gutiérrez Hermoso <jordigh at octave.org>
> > # Date 1571688404 14400
> > #      Mon Oct 21 16:06:44 2019 -0400
> > # Node ID 608193de8560218cc27032977bc380cb8dc0f3f8
> > # Parent  d782cce137fd1d50cccfecf8ccb17a623fde8800
> > grep: warn on censored revisions instead of erroring out
> 
> Can you add some tests?

Done.

> Might be better to fail if censor.policy != ignore.

I can't see why anyone could want grep to error out early, so I'm
going to keep it as is and I propose an addendum to the censor docs
instead.

> Nit: messages are all lowercase in general.
[..]
> Nit: filename must be bytes. bytestr() shouldn't be needed.

Fixed and fixed.



More information about the Mercurial-devel mailing list